Create accessor methods to XMLRPC::Config #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to add accessors for the other items.
kou
reviewed
Aug 21, 2023
lib/xmlrpc/config.rb
Outdated
| :ENABLE_MULTICALL, | ||
| :ENABLE_INTROSPECTION | ||
| ].each do |option| | ||
| define_singleton_method("#{option.downcase}") do |
There was a problem hiding this comment.
Could you append ? only for ENABLE_*?
For example, enable_nil_create? for :ENABLE_NIL_CREATE.
There was a problem hiding this comment.
I added predicate methods for all the boolean values, and updated the calling code to use the predicates instead.
There was a problem hiding this comment.
Thanks.
But do we need both of enable_nil_create and enable_nil_create??
There was a problem hiding this comment.
Probably not. I've removed the enable_nil_create and friends for the boolean options.
Make it read more like a boolean
kou
reviewed
Aug 23, 2023
lib/xmlrpc/config.rb
Outdated
| end | ||
|
|
||
| define_singleton_method("#{option.downcase}=") do |value| | ||
| module_eval do |
There was a problem hiding this comment.
Turns out we don't. I copy-pasted this from some code we had for changing the config options, but that was run from another module than Config.
I'ts gone now.
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the config is made up of a number of constants, changing the config does require some boilerplate to redefine constants. An example:
This change adds accessor methods to the Config module, so you can simply write them like this:
It still uses the constants under water, which means it is fully backwards compatible (which was the big objection in #39 )