Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test path additions and engine creation #22

Merged
merged 4 commits into from
Aug 12, 2022
Merged

Test path additions and engine creation #22

merged 4 commits into from
Aug 12, 2022

Conversation

ngan
Copy link
Collaborator

@ngan ngan commented Aug 12, 2022

No description provided.

@ngan ngan changed the title Add some tests Test path additions and engine creation Aug 12, 2022
alexevanczuk
alexevanczuk approved these changes Aug 12, 2022
View reviewed changes
Copy link
Contributor

@alexevanczuk alexevanczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@alexevanczuk
Copy link
Contributor

I think we just need to tell sorbet to ignore spec/fixtures

@alexevanczuk
Copy link
Contributor

I just pushed that change from the GitHub web editor 😎

@alexevanczuk alexevanczuk merged commit 2d12203 into main Aug 12, 2022
@alexevanczuk alexevanczuk deleted the np-add-tests branch August 12, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexevanczuk alexevanczuk alexevanczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngan @alexevanczuk