Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Packs specification #46

Merged
merged 3 commits into from
Dec 28, 2022
Merged

Use Packs specification #46

merged 3 commits into from
Dec 28, 2022

Conversation

alexevanczuk
Copy link
Contributor

@alexevanczuk alexevanczuk commented Dec 13, 2022

This PR extracts the idea of packs into the packs gem, which is located here: https://github.com/rubyatscale/packs.

The idea of doing this is that the rest of the toolchain depends on the idea of packs, but currently does so through parse_packwerk. For example, rubocop-packs, pack_stats, use_packs, code_ownership, and more. Rather than rely on stimpack directly, which has rails adjacent dependencies which we want to avoid to keep the idea of packs relevant even without rails, extracting packs helps all the tools depend on a common, simple, rarely changing standard.

@technicalpickles
Copy link

Makes a lot of sense to me 👍🏻

@alexevanczuk alexevanczuk force-pushed the ae-use-packs branch 3 times, most recently from 480c676 to 63ae75b Compare December 21, 2022 13:41
@alexevanczuk alexevanczuk marked this pull request as ready for review December 28, 2022 12:59
@alexevanczuk alexevanczuk merged commit 1176753 into main Dec 28, 2022
@alexevanczuk alexevanczuk deleted the ae-use-packs branch December 28, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants