Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to set custom engine name #65

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

timfsw
Copy link
Contributor

@timfsw timfsw commented Jul 21, 2023

I've needed a possibility to set a custom engine namespace to create different engines with same package folder name.

Currently the following package structure creates the same engine Authentication::Engine

# packs/backend/authentication/package.ym
metadata:
  engine: true
# packs/frontend/authentication/package.yml
metadata:
  engine: true

Now it's possible to set a custom engine name to prevent this issue.

# packs/backend/authentication/package.ym
metadata:
  engine: true
  engine_name: backend/authentication
# packs/frontend/authentication/package.yml
metadata:
  engine: true
  engine_name: frontend/authentication

This will generate the following engines: Backend::Authentication::Engine and Frontend::Authentication::Engine

I think it is better to specify the name explicitly instead of generating the package name based on the folder structure.

@professor
Copy link
Contributor

@ngan any thoughts on this PR?

If I understand the problem we are trying to solve, then another solution to this PR would be to change the behavior to make frontend/authentication be the auto-magic engine name instead of authentication

Copy link
Contributor

@professor professor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this. Long-term, we would like to remove engine support from packs.

@professor professor merged commit 0e1b4c1 into rubyatscale:main Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants