Docs/fix for rails 6.0 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoping to contribute some small improvements to the documentation. I ran into a few errors in a rails 6.0.x app, hopefully this saves some pain for others. https://github.com/rails/rails/blob/6-1-stable/actionpack/CHANGELOG.md
ngan
reviewed
Oct 19, 2023
|
@ngan ptal! |
ngan
reviewed
Oct 20, 2023
technicalpickles
requested changes
Oct 23, 2023
|
@ngan @technicalpickles ptal :) |
technicalpickles
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping to contribute some small improvements related to rails routing on older rails version 6.0. I ran into a few errors in a rails 6.0.x app, hopefully this saves some pain for others.
https://github.com/rails/rails/blob/6-1-stable/actionpack/CHANGELOG.md and https://github.com/rails/rails/pull/37892/files
The errors I got were:
@app.paths['config/routes']is nil. This is "fixed" by skipping that path or any other nil paths when injecting pathsdrawfunction is undefined when calling it in root routes.rb file. I added a note in README about requiring rails 6.1 for this function.Open to feedback on approach