Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update routes documentation in README.md #70

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Update routes documentation in README.md #70

merged 1 commit into from
Nov 17, 2023

Conversation

kpumuk
Copy link
Contributor

@kpumuk kpumuk commented Nov 16, 2023 •
edited
Loading

The routes in config/routes/*.rb should not include Rails.application.routes.draw block, see Rails Routing from the Outside In: Breaking Up Very Large Route File into Multiple Small Ones

Corresponding thread in Slack: #rubyatscale

Closes #69

@alexevanczuk
Copy link
Contributor

cc @ngan could ya take a look at this one?

ngan
ngan approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@ngan ngan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ngan ngan merged commit 3092185 into rubyatscale:main Nov 17, 2023
5 checks passed
@kpumuk kpumuk deleted the patch-1 branch January 29, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngan ngan ngan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readme routing example has a zeitwerk bug
3 participants
@kpumuk @alexevanczuk @ngan