-
Notifications
You must be signed in to change notification settings - Fork 112
Support a 256 colour set in modern terms. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I plan to use Paint in the future to achieve this. In the best case, I want to use the colors defined in the CSS scheme for this, but we could work on an intermediate solution which adds a 256 default style that is suitable for your cases, too. What do you think about this? |
I'd be more than happy to help implement paint (even though I kinda |
In defense of Jan, I know him (we went to the same university) and he's not a spammer ;-) I think he just likes to do things because they are possible. For me, the current colors work okay, but I also see a lot of room for improvement. However, since you seem to work a lot with CodeRay::Encoders::Terminal, I would be happy to let you choose the colors of the default style :-) Maybe based on your favorite/homegrown VIM highlight config or something. |
This feature, together with the multiline-inline-diff branch, would make a great 1.1 release :-) Just thinking. |
Well if you want some help implementing this (or even help working on |
Jordon Bedwell:
Never used gtalk before... kornelius@sofatutor.com should work :)
|
Hi Jordon! Do you still want to work on this feature? :) |
Yes I would love to help with this feature. We were just talking about this in #pry the other day. I'll start working on it today and see what I can come up with and present it to you so we can get a robust implementation. |
There is a ticket in Redmine that is possibly related to this: Let Terminal encoder use CSS styles With a link to: terminal256.py in the Pygments repo. Though I'm not sure that they use CSS styles. Pygments has its own definition of Style. |
See also, #29. |
256-color support could be the star feature of 1.2, but I think it should not delay 1.1 (which focusses on new scanners). |
All modern Linux terms support 256 colours (Gnome-Terminal [even though it doesn't advertise it and pretends to only support 8 colours -- and most other terminals provided and supported on GNOME, KDE and XFCE.) I'm asking and offering to help with this problem specifically because on a modern terminal with modern monitor the current colour set is pretty bright and blinding (exp: those blues kill) and some other colours tend to be harder to see unless they are darker (especially if you are using gnome-terminal with a transparent background.)
Coderay can detect colours using
tput colors
(but on Gnome-Terminal it will report 8 so you should assume 256 colours because it supports it -- read above) it can also grep out TERM for 256 (in the case of multiplexors but they will also output the right colours withtput colors
) Anyways the idea is to make things more readable, force your VIM to use 256 colours in a GNOME-Terminal and see what I mean when it changes the default themes line number colours to a dark orange. Example code to prove my point in VIM:The text was updated successfully, but these errors were encountered: