Additional options for parsing env variables #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… like "SETTINGS__FOLDER__MY_KEY". - env_prefix: change the prefix for the env vars to be processed - env_separator: set the symbol or symbols on which to split - env_converter: set to :downcase to change MY_KEY to my_key - env_parse_values: convert integer-like env values to integers
|
Please let me know if there is interest in this feature, in which case I'll rebase the changes on top of master so it can be merged. |
|
This also fixes #138 , I think? [Edit: fixed ID] |
|
@cbeer I think you mixed up the case ID |
|
Fixed, thanks. This would be really useful for using e.g. AWS ElasticBeanstalk with config. |
|
👍 Yes, it should fix #138 as well. We are running several of our apps as Docker containers in Dockercloud, and it is far easier to set env vars than to mount a config file. |
pkuczynski
added a commit
that referenced
this pull request
May 12, 2016
Additional options for parsing env variables #125
|
This is a really good idea and implementation! I just merged it in and will prepare release 1.2.0. I also updated some documentation and added new options to Rails initializer |
This was referenced May 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting env vars like "SETTINGS__FOLDER__MY_KEY".
This is similar to #119, but builds on the existing
env_load!method and provides further customisation on the format of the env variables. It should fix #108.