Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 3.2 to test matrix #337

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Add Ruby 3.2 to test matrix #337

merged 1 commit into from
Jul 18, 2023

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented May 24, 2023

No description provided.

@y-yagi
Copy link
Contributor Author

y-yagi commented May 24, 2023

Hmm. It seems CI is broken now. https://github.com/rubyconfig/config/actions/runs/4876081705/jobs/8699118492

pkuczynski
pkuczynski previously approved these changes May 24, 2023
View reviewed changes
@pkuczynski
Copy link
Member

Hmm. It seems CI is broken now. rubyconfig/config/actions/runs/4876081705/jobs/8699118492

Looks like it is. Not sure why, but it can't run appraisal anymore

@pkuczynski
Copy link
Member

I fixed CI. It was broken for some time and I didn't noticed. Let's see if your PR pass through...

@pkuczynski
Copy link
Member

Unfortunatelly 3.2 fails with appraisal, but I am not sure why and I won't have time to work on it. Would you like to spare some time for it?

@y-yagi y-yagi marked this pull request as ready for review May 24, 2023 22:27
@y-yagi
Copy link
Contributor Author

y-yagi commented May 24, 2023

@pkuczynski Thanks for your help!
I assume the released appraisal has a problem with the latest bundler. So I've changed to use appraisal from the git.
Ref: thoughtbot/appraisal#210

I confirmed this work on my local fork. https://github.com/y-yagi/config/actions/runs/5073993153/jobs/9113686334?pr=2

@y-yagi y-yagi force-pushed the run-test-against-ruby32 branch from c411e96 to e0f8011 Compare May 24, 2023 23:05
@pkuczynski
Copy link
Member

I don't think this is a best idea and I would prefer to use appraisals from rubygem. Maybe you could reach out to their repo and report a bug? Maybe they will release new version soon?

@y-yagi
Copy link
Contributor Author

y-yagi commented May 25, 2023

OK. The issue already exists(I mentioned it in my before comment). I just added a comment.

@krasnoukhov krasnoukhov mentioned this pull request Jun 1, 2023
Merged
@y-yagi y-yagi force-pushed the run-test-against-ruby32 branch from e0f8011 to e0907c9 Compare July 15, 2023 08:48
@y-yagi
Copy link
Contributor Author

y-yagi commented Jul 15, 2023

The new version of appraisal released.
thoughtbot/appraisal@feb78bc

I removed the commit related to appraisal and it seems to work well https://github.com/y-yagi/config/actions/runs/5561411613

@pkuczynski pkuczynski merged commit c790118 into rubyconfig:master Jul 18, 2023
@pkuczynski
Copy link
Member

Thanks!

@y-yagi y-yagi deleted the run-test-against-ruby32 branch July 18, 2023 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

@amatsuda amatsuda amatsuda approved these changes

Assignees
No one assigned
Labels
improvement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@y-yagi @pkuczynski @amatsuda