Skip to content

Commit

Permalink
fix: flaky case_contact index (#5885)
Browse files Browse the repository at this point in the history
Potentially unflakes the test. My theory is that sometimes the draft
would appear before the real test because both were using
Time.zone.today for the time.

I hardcoded more values to improve consistency.
  • Loading branch information
elasticspoon authored Jul 6, 2024
1 parent d057a38 commit a4d983d
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions spec/system/case_contacts/index_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,11 @@
context "without filter" do
let(:case_contacts) do
[
create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.yesterday - 1),
create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.yesterday),
create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.today),
create(:case_contact, :started_status, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.today,
create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: 2.days.ago),
create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: 1.days.ago),
create(:case_contact, creator: volunteer, casa_case: casa_case, occurred_at: Time.zone.now,
contact_types: [create(:contact_type, name: "Most Recent Case Contact")]),
create(:case_contact, :started_status, creator: volunteer, casa_case: casa_case, occurred_at: 3.days.ago,
contact_types: [create(:contact_type, name: "DRAFT Case Contact")])
]
end
Expand Down Expand Up @@ -56,9 +57,8 @@
case_contacts
sign_in volunteer
visit case_contacts_path
within(".card-title", match: :first) do
expect(page).to have_text(case_contacts[2].contact_groups_with_types.keys.first)
end
expect(page).to have_text("Most Recent Case Contact")
expect(page).to have_text("DRAFT Case Contact")
end
end

Expand Down

0 comments on commit a4d983d

Please sign in to comment.