fix n+1 queries

rubyforgood · Oct 4, 2024 · c99832a · c99832a
1 parent 79ca251
commit c99832a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/helpers/ui_helper.rb b/app/helpers/ui_helper.rb
@@ -5,14 +5,14 @@ def grouped_options_for_assigning_case(volunteer)
     [
       [
         "Not Assigned",
-        CasaCase
+        CasaCase.eager_load([:assigned_volunteers])
           .not_assigned(@volunteer.casa_org).active
           .uniq { |casa_case| casa_case.case_number }
           .map { |casa_case| ["#{casa_case.case_number} - #{volunteer_badge(casa_case, current_user)}".html_safe, casa_case.id] }
       ],
       [
         "Assigned",
-        CasaCase
+        CasaCase.eager_load([:assigned_volunteers])
           .actively_assigned_excluding_volunteer(@volunteer)
           .uniq { |casa_case| casa_case.case_number }
           .map { |casa_case| ["#{casa_case.case_number} - #{volunteer_badge(casa_case, current_user)}".html_safe, casa_case.id] }

diff --git a/app/models/volunteer.rb b/app/models/volunteer.rb
@@ -97,7 +97,7 @@ def deactivate
   end
 
   def case_assignments_with_cases
-    case_assignments.includes(:casa_case)
+    case_assignments.includes(casa_case: :assigned_volunteers)
   end
 
   def has_supervisor?