[5894] Fix VolunteersController#edit N+1 issues #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticspoon
approved these changes
Oct 8, 2024
| @@ -5,14 +5,14 @@ def grouped_options_for_assigning_case(volunteer) | |||
| [ | |||
| [ | |||
| "Not Assigned", | |||
| CasaCase | |||
| CasaCase.eager_load([:assigned_volunteers]) | |||
There was a problem hiding this comment.
did you choose eager_load over includes on purpose? includes will choose to use eager_load or preload. It doesn't matter that much but just curious
There was a problem hiding this comment.
In this case, I followed the recommendation of Bullet gem.
Firstly, include was suggested, but when added a new recommendation appeared with eager_load. (I didn't take a new screenshot)
|
@elasticspoon, I have a question: Can I merge it once it's approved, or is this only done by project owners? |
Feel free to merge yourself. Or you can wait for me to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5894
What changed, and why?
When editing a Volunteer, an N+1 query occurred.
After the changes, it doesn't happen an the code is faster.
How is this tested? (please write tests!) 💖💪
N+1 queries are tested with Bullet gem, a message is shown in the console
Screenshots please :)
Previous queries
Actual queries