Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start use ffaker and refact some tests #95

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions rails/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ group :development, :test do
gem "byebug", platforms: %i[mri mingw x64_mingw]
gem "dotenv-rails", "~> 2.7"
gem "factory_bot_rails"
gem "ffaker", "~> 2.13.0"
gem "pry"
end

Expand All @@ -66,7 +67,6 @@ end
group :test do
gem "capybara"
gem "rspec-rails"

gem "selenium-webdriver"
gem "teaspoon", github: "jejacks0n/teaspoon", branch: "master"
gem "teaspoon-mocha"
Expand All @@ -84,5 +84,3 @@ gem "jquery-rails"
# get service-workers to play nicely with rails
gem "rails-i18n"
gem "serviceworker-rails", "~> 0.6"

gem "faker", "~> 1.9"
352 changes: 0 additions & 352 deletions rails/Gemfile.lock

This file was deleted.

4 changes: 2 additions & 2 deletions rails/spec/factories/nursery_tables.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
FactoryBot.define do
factory :nursery_table do
capacity { 12 }
name { "nursery" }
capacity { rand(1..500) }
name { FFaker::Name.name }
zone_id { 1 }
end
end
4 changes: 4 additions & 0 deletions rails/spec/factories/restoration_activity_log_entries.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
FactoryBot.define do
factory :restoration_activity_log_entry do
cleaned { FFaker::Boolean.random }
corals_added { rand(0..100) }
dead_corals { rand(0..100) }
bleached_corals { rand(0..100) }
end
end
Loading