Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'diaper pick up person' internal mechanisms to be just pick up person to be more general. #3326

Closed
2 tasks
scooter-dangle opened this issue Jan 15, 2023 · 4 comments · Fixed by #3624
Closed
2 tasks
Assignees
Labels
Help Wanted Groomed + open to all! 🔧 Tech Debt Maintance. We should pay this off someday!

Comments

@scooter-dangle
Copy link
Collaborator

Why

Technical debt: reduction of confusion to future developers

Details

The external language for this has already been changed, but the partial for pickup person, and the mechanics for the essentials bank to choose whether to include pickup person or not in the partner form need to be updated.

Complexity: It needs to have the partial and references to it renamed, and current data around the partner form may have to be changed. [I'm not sure if it's stored as string or an enum]


Criteria for completion

  • diaper_pickup_person is pickup_person in the code and in the data
  • all related tests pass.
@tacohole
Copy link
Contributor

Hey there! Got a PR up for this one here: #3357

@cielf cielf added the 🔧 Tech Debt Maintance. We should pay this off someday! label Jan 30, 2023
@lokisk1155
Copy link
Collaborator

I can take this one!

@dorner
Copy link
Collaborator

dorner commented May 22, 2023

Go for it!

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This issue has been inactive for 251 hours (10.46 days) and will be automatically unassigned after 109 more hours (4.54 days).

cielf added a commit that referenced this issue Jun 3, 2023
#3326 Change 'diaper pick up person' internal mechanisms to be just pick up person to be more general.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Groomed + open to all! 🔧 Tech Debt Maintance. We should pay this off someday!
Projects
None yet
5 participants