You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Disable double click and dialog close on distribution and request confirmations
Why?
This can cause bad things to happen, disrupting the event sourcing and ultimately causing a bank to be unable to process any transactions
Details
The confirmations in question are:
1/ Request confirmation
Navigation: sign in as verified@example.com. Chose Quantity. Fill in the form including at least one item/quantity pair, and click save. A confirmation will appear -- this is the confirmation screen we are talking about.
Both buttons should be disabled once the "yes, it's correct" button is clicked.
Please also change the colour of the "yes, it's correct" button to green (like the save button on the request)
2/ Distribution confirmation
Navigation: sign in as org_admin1@example.com. Choose Distributions , then click "+New Distribution". Choose a Partner and a "From storage location", then select an item and fill in a quantity. Click Save. A confirmation will appear -- this is the confirmation screen we are talking about.
Both buttons should be disabled once the "yes, it's correct" button is clicked.
Both buttons should be disabled once the "yes, it's correct" button is clicked.
Please also change the colour of the "yes, it's correct" button to green (like the save button on the distribution)
Criteria for completion
behaviour as described above
autoated tests confirming the behaviour
The text was updated successfully, but these errors were encountered:
Despite running cpulimit, dev tool cpu throttling and network throttling I was unable to recreate a double submission where two events were created due to doubleclick or when clicking Yes followed by No.
I can disable the buttons and write tests to check if buttons are disabled, but I'm not sure what bad things can happen or what to test to avoid those bad things happening
Please do disable the buttons appropriately. IIRC the bad thing that can happen is a creation of two records where one was meant .
Background: We had some of this issue quite some time ago, and took the hygiene step of disabling the various save buttons once clicked. That cleared it up, but we've seen it again since we introduced the confirmation step. So disabling the buttons once clicked is an important hygiene step.
Summary
Disable double click and dialog close on distribution and request confirmations
Why?
This can cause bad things to happen, disrupting the event sourcing and ultimately causing a bank to be unable to process any transactions
Details
The confirmations in question are:
1/ Request confirmation
Navigation: sign in as verified@example.com. Chose Quantity. Fill in the form including at least one item/quantity pair, and click save. A confirmation will appear -- this is the confirmation screen we are talking about.
Both buttons should be disabled once the "yes, it's correct" button is clicked.
Please also change the colour of the "yes, it's correct" button to green (like the save button on the request)
2/ Distribution confirmation
Navigation: sign in as org_admin1@example.com. Choose Distributions , then click "+New Distribution". Choose a Partner and a "From storage location", then select an item and fill in a quantity. Click Save. A confirmation will appear -- this is the confirmation screen we are talking about.
Both buttons should be disabled once the "yes, it's correct" button is clicked.
Both buttons should be disabled once the "yes, it's correct" button is clicked.
Please also change the colour of the "yes, it's correct" button to green (like the save button on the distribution)
Criteria for completion
The text was updated successfully, but these errors were encountered: