Issue 3472: Bring request info to distribution #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Mar 27, 2023
grantmca
force-pushed
the
3472-add-user-request-details-to-distribution
branch
4 times, most recently
from
19e3758
to
07d4323
Compare
dorner
requested changes
Mar 31, 2023
grantmca
force-pushed
the
3472-add-user-request-details-to-distribution
branch
from
07d4323
to
0278e35
Compare
dorner
approved these changes
Mar 31, 2023
|
Once tests pass this should be good to merge! |
Added ability to automatically populate the agency representatives name
and email address in the distribution form
Added function to user to return a string that formatted the
partner_user's name in email for the front end on both the request show
and to be used in the distribution's controller to populate the agency
representatives bald
Added a test to ensure that the partner, agency representatives and
comments are all properly being passed from the request to the distribution
using the #copy_from_request function
grantmca
force-pushed
the
3472-add-user-request-details-to-distribution
branch
from
0278e35
to
466a8e7
Compare
|
Nice - thanks! |
|
@grantmca for next time, please don't force push your branch if it's got active conversations on it - it becomes a lot harder to figure out what's changed since the last time a comment was made. We can always squash it on merge. |
|
@grantmca -- Just to let you know -- this has been released. Thank you! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3472
Description
Added automatic population of the agency representatives name and email address in the distribution form based around the
copy_from_requestmethod in the distribution model. I also added a function to user model to return a formatted version of the partenr_users name and email for the front end table in request as well as the filling in of agency representatives. I did this through a function to keep things DRY.Added a test to ensure that the partner, agency representatives and
comments are all properly being passed from the request to the distribution
using the #copy_from_request function
Type of change
How Has This Been Tested?
I have added a test and I have also tested manually, manual testing steps would be
Test to verify changes : bundle exec rspec spec/system/distribution_system_spec.rb:398
Screenshots