Issue 3515 Remove Duplicate Code in adjustments.js #3539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed comment on adjustments.js mentioning duplicate code on this page. This code was used to update the drop down options when 1. The Storage Location of the adjustment was changed 2. When additional Item inputs were added using the `add another item` button This code is duplicated in distribution_and_transfers.js in the request_storage_location_and_populate_item function and the unnamed guncotton on line 61 of the file.
grantmca
changed the title
grantmca
changed the title
dorner
approved these changes
Apr 18, 2023
|
Nice - thanks for the contribution! |
|
Hey @grantmca - Just letting you know this is in production now. Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3515
Description
Addressed comment on adjustments.js mentioning duplicate code on this page. This code was used to update the drop down options when
add another itembuttonThis code is duplicated in distribution_and_transfers.js in the request_storage_location_and_populate_item function and the unnamed function on line 61 of the file.
Type of change
How Has This Been Tested?
Tested manually by ensuring that the user is able to successfully add new items on adjustments and the items update automatically and also that when a new storage location is picked all of the items update automatically.