3540: Fix bad user roles #3550
Merged
3540: Fix bad user roles #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
reviewed
Apr 23, 2023
|
|
||
| bad_roles.each do |role| | ||
| UsersRole.where(role_id: role.id).destroy_all | ||
| role.destroy |
There was a problem hiding this comment.
Should we do
Suggested change
| role.destroy | |
| role.destroy! |
so if something goes wrong it gets angrier?
There was a problem hiding this comment.
Hmm... no, I don't think so. We can verify the data afterwards if something failed to delete, but I wouldn't want it to hold up the rest of the migration.
|
Should we change this in the Role model to not be optional? |
awwaiid
approved these changes
Apr 23, 2023
|
FWIW. I checked the latest version against local data too -- have the right numbers of bank roles and partner roles afterwards -- as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3540
Description
This finds roles that don't have corresponding resources, and tries its darndest to update them so they do.
Type of change
How Has This Been Tested?
Local data