fix: made updates to import partners modal #3600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
May 16, 2023
There was a problem hiding this comment.
@DariBerrie loving the additional fixes around the main issue here! One comment and one question.
app/assets/stylesheets/custom.scss
Outdated
| } | ||
| #csvImportModal .modal-header { | ||
| flex-direction: row; | ||
| justify-content: center; |
| <li> | ||
| <%= f.file_field :file, accept: 'text/csv', class: 'form-control-file', style: "margin: auto;" %> | ||
| </li> | ||
| <li style="margin-bottom: 27px;">Then click the "Import CSV" button to import your <%= import_type.downcase %>.</li> | ||
| <li style="margin-bottom: 27px;">Then click the "Import CSV" button to import your partners.</li> |
There was a problem hiding this comment.
Wouldn't this show the same text for other import CSV modals though?
| @@ -37,7 +37,7 @@ | |||
| </div><!-- / row --> | |||
| </div><!-- /.modal-body --> | |||
| <div class="modal-footer"> | |||
| <small>Note: You're only able to run the import one time to prevent accidental imports or writing over existing locations!</small> | |||
| <small>Note: You're only able to run the import one time to prevent accidental imports or writing over existing partners!</small> | |||
|
@dorner Let me know if this looks okay. I can make additional changes if needed :) |
dorner
approved these changes
Jun 2, 2023
|
Working now! Woot! |
|
Awesome! I was worried when I saw those tests fail 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3585
Description
I updated the text on the Import Partners modal to improve clarity for users. I also made some small style changes to the text like using capitalized CSV for all mentions, adjusting the alignment of text, and matching button sizes for both columns.
I believe all CSS changes are unique to the modal, since the _csv_import_modal.html.erb only uses partners terminology. If it is used elsewhere and may affect the modal's appearance, I can check what would be best to standardize the modals.
Let me know what you think! Would welcome any feedback!
List any dependencies that are required for this change. (gems, js libraries, etc.) None.
Type of change
How Has This Been Tested?
Only made text changes and CSS changes that can be seen on the modal page. Screenshots provided below.
Screenshots