Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show 'Total Items' instead of 'Total Diapers' on Product Participant, Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers #3645

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

sgtm2000
Copy link
Contributor

@sgtm2000 sgtm2000 commented Jun 6, 2023

Resolves #3639

Description

Show 'Total Items' instead of 'Total Diapers' on Product Participant, Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers

How Has This Been Tested?

Checked index pages for "Product Drive Participants", "Vendors" and "Manufacturers" locally

Screenshots

Screen Shot 2023-06-05 at 10 14 57 PM Screen Shot 2023-06-05 at 10 14 20 PM Screen Shot 2023-06-05 at 10 14 11 PM

@sgtm2000 sgtm2000 changed the title Show 'Total Items' instead of 'Total Diapers' on Product Participant, … Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers [WIP] Show 'Total Items' instead of 'Total Diapers' on Product Participant, … Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers Jun 6, 2023
@sgtm2000 sgtm2000 changed the title [WIP] Show 'Total Items' instead of 'Total Diapers' on Product Participant, … Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers Show 'Total Items' instead of 'Total Diapers' on Product Participant, … Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers Jun 7, 2023
@sgtm2000 sgtm2000 changed the title Show 'Total Items' instead of 'Total Diapers' on Product Participant, … Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers Show 'Total Items' instead of 'Total Diapers' on Product Participant, Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers Jun 7, 2023
… Vendors, and Manufacturers Index page to be inclusive of banks that don't do diapers
@sgtm2000 sgtm2000 force-pushed the 3639-total-items-not-diapers branch from bba87d7 to 3102514 Compare June 7, 2023 03:33
@sgtm2000 sgtm2000 marked this pull request as ready for review June 7, 2023 03:34
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick and easy! Thanks!

@dorner dorner merged commit 6834f64 into rubyforgood:main Jun 7, 2023
@cielf
Copy link
Collaborator

cielf commented Jun 27, 2023

@sgtm2000 This went into production on Sunday. Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product participant index shows "total diapers" Should show "total items"
3 participants