Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display partner request's total items in request history #3646

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

kamck
Copy link
Contributor

@kamck kamck commented Jun 7, 2023

Resolves #3640 Request History on partner should show # of items instead of request id

Description

Replaces the request ID with the total number of items in request on Request History page. This is to provide useful information to partners and reduce partner confusion. Used existing method Request#total_items in partners/requests/_history.html.erb partial.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Change can be viewed by performing the following

  1. Sign in as verified user.
  2. Click the "Essential Requests" link in left navigation.
  3. Scroll to request history.
  4. The "Items Requested" field now reflects the total quantity of items in the request instead of the request ID.

Screenshots

image

@kamck kamck force-pushed the 3640-total-items-in-request-history branch from abafdda to 24b4ac5 Compare June 7, 2023 14:24
Copy link
Collaborator

@dorner dorner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@dorner dorner merged commit 99d649b into rubyforgood:main Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request History on partner should show # of items instead of request id
2 participants