3558 Add validations for partner requests settings #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacur
force-pushed
the
3558-validate-partner-profile-request-settings
branch
from
8855154
to
98aed5f
Compare
dacur
force-pushed
the
3558-validate-partner-profile-request-settings
branch
from
98aed5f
to
11013a3
Compare
dacur
changed the title
dacur
force-pushed
the
3558-validate-partner-profile-request-settings
branch
from
11013a3
to
8788946
Compare
seanmarcia
approved these changes
Jun 7, 2023
dorner
requested changes
Jun 7, 2023
app/models/partners/profile.rb
Outdated
| @@ -129,5 +130,9 @@ def client_share_is_0_or_100 | |||
| errors.add(:base, "Total client share must be 0 or 100") | |||
| end | |||
| end | |||
|
|
|||
| def has_at_least_one_request_setting | |||
| errors.add(:base, "At least one request type must be set") unless enable_child_based_requests || enable_individual_requests || enable_quantity_based_requests | |||
There was a problem hiding this comment.
I prefer using if ! instead of unless if there's more than one condition - I can never remember how it reads otherwise.
…st version of Ruby.
dacur
force-pushed
the
3558-validate-partner-profile-request-settings
branch
from
8788946
to
4df17b4
Compare
dorner
approved these changes
Jun 11, 2023
|
Thanks for the contribution! FYI for next time - if there is an active review, please don't force push changes, as it is more difficult to see what changed since the review. |
|
@dorner Gotcha, thanks :) |
dacur
pushed a commit
that referenced
this pull request
Jun 12, 2023
dorner
pushed a commit
that referenced
this pull request
Jun 13, 2023
|
@dacur This went into production on Sunday. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3558
Description
Adds a validation so that a partner cannot entirely remove their own ability to make requests through the partner profile. Also adds tests for this change, and updated a failing spec that was caused by this change.
Other changes include:
.vscode/to.gitignoreType of change
How Has This Been Tested?
Added tests and ran the entire test suite.