Move to Newrelic for logging and APM #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awwaiid
reviewed
Jul 9, 2023
| @@ -16,6 +16,7 @@ class ApplicationController < ActionController::Base | |||
|
|
|||
| def current_organization | |||
| return @current_organization if @current_organization | |||
| return nil unless current_role | |||
There was a problem hiding this comment.
This looks good and correct but is unrelated, yes?
awwaiid
reviewed
Jul 9, 2023
| config.lograge.enabled = true | ||
| config.lograge.custom_payload do |controller| | ||
| { | ||
| host: controller.request.host, | ||
| user_id: controller.current_user.try(:id) | ||
| user_id: controller.current_user.try(:id), |
There was a problem hiding this comment.
oh, maybe the nil returns were to help these!
awwaiid
reviewed
Jul 9, 2023
config/newrelic.yml
Outdated
|
|
||
| common: &default_settings | ||
| # Required license key associated with your New Relic account. | ||
| license_key: 9942120fb257ae099f776017cd6926a760e6NRAL |
There was a problem hiding this comment.
Should this be pulled from an ENV? I think the worst case is someone submitting bogus data to NR, and since we have a free account even if our resources get used up it wouldn't be the worst thing ever, so maybe fine for now.
There was a problem hiding this comment.
Good catch. Updated this.
awwaiid
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3706
Description
Adds Newrelic APM integration and removes Skylight.
Once this is merged, I will add info to the Gitbook related to this.
Type of change
Infrastructure change
How Has This Been Tested?
Deployed to staging.