Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3554 Allow superadmins to manage roles #3720

Merged
merged 8 commits into from
Jul 16, 2023
Merged

3554 Allow superadmins to manage roles #3720

merged 8 commits into from
Jul 16, 2023

Conversation

dorner
Copy link
Collaborator

@dorner dorner commented Jul 7, 2023

Resolves #3354

Description

This adds the ability for superadmins to view, remove and add roles to existing users.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Local testing. Unit/system tests coming next.

Screenshots

image

^ This now shows up at the bottom of the Edit User page.

@dorner dorner marked this pull request as ready for review July 9, 2023 15:20
@dorner dorner changed the title [WIP] 3554 Allow superadmins to manage roles 3554 Allow superadmins to manage roles Jul 9, 2023
@awwaiid
Copy link
Collaborator

awwaiid commented Jul 9, 2023

@dorner looks like relevant legit spec failures

Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix tests; my initial local QA worked but I didn't try to reproduce what the tests are doing

@dorner dorner requested a review from awwaiid July 9, 2023 19:24
Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cod looks good and I QA'd locally too. Thank you!

@awwaiid awwaiid merged commit 8c4c6f4 into main Jul 16, 2023
@awwaiid awwaiid deleted the 3554-superadmin-roles branch July 16, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give superadmins the ability to manage user roles
2 participants