Product totals - custom units #4609

awwaiid · 2024-08-25T02:11:39Z

Implement #4408

Adds units when feature is enabled and there are any units
Changes sort to be by name instead of by qty

Verified that in production there are zero of these instances

awwaiid · 2024-08-25T02:12:57Z

spec/services/requests_total_items_service_spec.rb

@@ -23,23 +23,8 @@
      end
    end

-    context 'when item name is nil' do


From a production snapshot:

pry(main)> Partners::ItemRequest.where(name: nil).count Partners::ItemRequest Count (15.1ms) SELECT COUNT(*) FROM "item_requests" WHERE "item_requests"."name" IS NULL => 0

cielf

1/ Could we use the plural for the custom units in this?
2/ We're putting a dash, but no unit when it's that situation where they just have units. maybe we should say "units" there.

awwaiid · 2024-09-01T15:03:03Z

I'm wondering which is better, Pads - units or Pads. Also ... the way we've implemented units elsewhere end up recording an empty string. We could maybe explicitly record "units" as the individual-units default recorded in the database.

cielf · 2024-09-01T16:49:48Z

Which is better is a fair question. Is it a Wednesday question?

dorner · 2024-09-02T17:56:49Z

I'd probably prefer it like this:

Pads (individual)
Pads (in packs)

cielf · 2024-09-02T18:52:24Z

I'd probably prefer it like this:

Pads (individual)

Pads (in packs)

I think (in packs) implies the number of pads that happen to be in packs, as opposed to the number of packs. I kind of like the parentheses, though.

This is still the whole naming things issue - but I think we should be consistent between what we use for the partners and what we use for the banks -- because they do have conversations.

How about:

Pads (units)
Pads (packs)

I don't like "units", because of the naming conflict with "Custom Request Units" , but it's what we got from the banks. We could check if "pieces" would work for them, maybe?

…nits

awwaiid · 2024-10-13T16:19:01Z

From our discussion on the call today, this is now updated to use plural when units are specified and blank otherwise.

cielf

Two wee things:
1/ The sort should be lower-case alpha. (we are standardizing on that)
2/ If we're not showing the unit, we shouldn't show the dash either, methinks.

…nits

awwaiid · 2024-11-03T17:58:29Z

Two wee things: 1/ The sort should be lower-case alpha. (we are standardizing on that) 2/ If we're not showing the unit, we shouldn't show the dash either, methinks.

Fixed!

Addressed.

cielf

LGTM. Over to @dorner for technical.

dorner

Mostly minor suggestions.

app/services/requests_total_items_service.rb

dorner · 2024-11-09T23:26:45Z

app/services/requests_total_items_service.rb

-    item_found = items_names.find { |item| item["id"] == id }
-    item_found&.fetch('name') || '*Unknown Item*'
+  def item_name(item_request)
+    if Flipper.enabled?(:enable_packs) && item_request.request_unit.present?


Didn't we extract this into a method in a different PR?

Yes, in the not-yet-merged PR. This refactor I think will make it trivial to cross-use the two -- like maybe we merge that other one first an then I'll update this one.

Eh. I made them identical now.

spec/services/requests_total_items_service_spec.rb

dorner · 2024-11-09T23:28:01Z

spec/services/requests_total_items_service_spec.rb

+
+        it 'return items with correct quantities calculated' do
+          expect(subject).to eq({
+            sample_items.first.name => 20,


Can we hardcode these names please?

Fixed! And then some!

Co-authored-by: Daniel Orner <daniel.orner@flipp.com>

…nits

[#4408]

dorner

LGTM!

github-actions · 2024-11-24T15:24:24Z

@awwaiid: Your PR Product totals - custom units is part of today's Human Essentials production release: 2024.11.24.
Thank you very much for your contribution!

awwaiid added 3 commits August 24, 2024 22:09

Implement custom units in request total popup

b429b8a

Sort request counts by name instead of by count

abfb8d2

Remove unneeded test, this case doesn't happen

b30fc82

Verified that in production there are zero of these instances

awwaiid commented Aug 25, 2024

View reviewed changes

awwaiid marked this pull request as ready for review August 25, 2024 02:57

awwaiid requested review from dorner and cielf August 25, 2024 02:58

awwaiid added this to the Request Units (Packs) milestone Aug 25, 2024

awwaiid linked an issue Aug 25, 2024 that may be closed by this pull request

[PACKS] #13 Calcuate Product Totals #4408

Closed

2 tasks

cielf reviewed Aug 27, 2024

View reviewed changes

awwaiid added 2 commits October 13, 2024 09:52

Merge remote-tracking branch 'origin/main' into 4408-product-totals-u…

4a133b7

…nits

Pluralize units and update spec [#4408]

ed81691

awwaiid requested a review from cielf October 13, 2024 16:19

cielf previously requested changes Oct 14, 2024

View reviewed changes

awwaiid added 3 commits November 3, 2024 12:51

Merge remote-tracking branch 'origin/main' into 4408-product-totals-u…

8bfed50

…nits

Do not show dash for blank unit

52f3665

Sort by the lower-cased name for consistency

582c7d4

awwaiid requested a review from cielf November 3, 2024 17:58

cielf reviewed Nov 7, 2024

View reviewed changes

dorner requested changes Nov 9, 2024

View reviewed changes

awwaiid and others added 3 commits November 17, 2024 15:47

Use default hash value

eccf524

Co-authored-by: Daniel Orner <daniel.orner@flipp.com>

Spec description improvement

0716780

Co-authored-by: Daniel Orner <daniel.orner@flipp.com>

Spec description improvement

0da4a6e

Co-authored-by: Daniel Orner <daniel.orner@flipp.com>

awwaiid added 3 commits November 17, 2024 16:08

Make item names explicit in test [#4408]

f33dfb8

Merge remote-tracking branch 'origin/main' into 4408-product-totals-u…

f6aa753

…nits

Unify on request item name with unit refactor across PRs

4b7d942

[#4408]

awwaiid requested a review from dorner November 17, 2024 21:18

dorner approved these changes Nov 22, 2024

View reviewed changes

dorner merged commit 1025cf5 into main Nov 22, 2024
22 checks passed

dorner deleted the 4408-product-totals-units branch November 22, 2024 01:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Product totals - custom units #4609

Product totals - custom units #4609

awwaiid commented Aug 25, 2024 •

edited

Loading

awwaiid Aug 25, 2024

cielf left a comment

awwaiid commented Sep 1, 2024

cielf commented Sep 1, 2024 •

edited

Loading

dorner commented Sep 2, 2024

cielf commented Sep 2, 2024 •

edited

Loading

awwaiid commented Oct 13, 2024

cielf left a comment

awwaiid commented Nov 3, 2024

cielf left a comment

dorner left a comment

dorner Nov 9, 2024

awwaiid Nov 17, 2024

awwaiid Nov 17, 2024

dorner Nov 9, 2024

awwaiid Nov 17, 2024

dorner left a comment

github-actions bot commented Nov 24, 2024

Product totals - custom units #4609

Product totals - custom units #4609

Conversation

awwaiid commented Aug 25, 2024 • edited Loading

awwaiid Aug 25, 2024

Choose a reason for hiding this comment

cielf left a comment

Choose a reason for hiding this comment

awwaiid commented Sep 1, 2024

cielf commented Sep 1, 2024 • edited Loading

dorner commented Sep 2, 2024

cielf commented Sep 2, 2024 • edited Loading

awwaiid commented Oct 13, 2024

cielf left a comment

Choose a reason for hiding this comment

awwaiid commented Nov 3, 2024

cielf left a comment

Choose a reason for hiding this comment

dorner left a comment

Choose a reason for hiding this comment

dorner Nov 9, 2024

Choose a reason for hiding this comment

awwaiid Nov 17, 2024

Choose a reason for hiding this comment

awwaiid Nov 17, 2024

Choose a reason for hiding this comment

dorner Nov 9, 2024

Choose a reason for hiding this comment

awwaiid Nov 17, 2024

Choose a reason for hiding this comment

dorner left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 24, 2024

awwaiid commented Aug 25, 2024 •

edited

Loading

cielf commented Sep 1, 2024 •

edited

Loading

cielf commented Sep 2, 2024 •

edited

Loading