4655: [BUG] If you have an error on entering a partner group, the Item Categories changes to a yes/no! Obviously wrong! #4668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… edit params are invalid
|
@victorhwmn FYI: We had an urgent fix that required all the senior contributors this week , so we didn't get to look at this. Hopefully this week will go better. |
dorner
reviewed
Sep 30, 2024
| describe "GET #new" do | ||
| subject { get new_partner_group_path } | ||
|
|
||
| it "renders the new template and assings variables correctly" do |
There was a problem hiding this comment.
fixed here fffd3e4
dorner
approved these changes
Oct 6, 2024
|
All good here! |
|
@victorhwmn: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4655
Description
In
partner_groups_controller.rbI created a methodset_items_categoriesto set the value of@item_categoriesand added it to thecreateandupdatemethods where it was missing.Type of change
How Has This Been Tested?
Follow the same steps from the issue
Now it should show all the available category items correctly
To test the
updatemethod you can start from the step: 'Choose the "Groups" tab' and then:Create two partner groups (if there are already at least two, you can skip this part)
Click "Edit" on one of them
Enter the same name as the other group
Click "Update Partner Group"