4745: Disable deactivate button for storage locations not deactivatable #4775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coalest
force-pushed
the
4745-disable-deactivate-button-unless-storage-location-is-deactibatable
branch
6 times, most recently
from
c94abee
to
3b71eca
Compare
coalest
force-pushed
the
4745-disable-deactivate-button-unless-storage-location-is-deactibatable
branch
from
3b71eca
to
f6028f8
Compare
dorner
requested changes
Nov 16, 2024
| <td><%= number_to_currency(storage_location.inventory_total_value_in_dollars(@inventory)) %></td> | ||
| <td class="text-right"> | ||
| <%= view_button_to storage_location %> | ||
| <%= edit_button_to edit_storage_location_path(storage_location) %> | ||
| <% if storage_location.discarded? %> | ||
| <%= reactivate_button_to storage_location_reactivate_path(storage_location), { confirm: confirm_reactivate_msg(storage_location.name) } %> | ||
| <% else %> | ||
| <%= deactivate_button_to storage_location_deactivate_path(storage_location), { confirm: confirm_deactivate_msg(storage_location.name) } %> | ||
| <%= deactivate_button_to storage_location_deactivate_path(storage_location), | ||
| { confirm: confirm_deactivate_msg(storage_location.name), enabled: @inventory_item_totals[storage_location.id].zero? } %> |
There was a problem hiding this comment.
Calculating the inventory total is super quick since it's all in memory. I think I'd rather not have the extra instance variable and do this check live.
There was a problem hiding this comment.
Removed that new instance variable.
…e-location-is-deactibatable
dorner
approved these changes
Nov 22, 2024
|
Thanks! |
|
@coalest: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4745
Description
We should only be able to deactivate storage locations with no inventory items.
Type of change
I guess a new feature?
How Has This Been Tested?
Added request specs for both paths (when
read_eventsfeature flag is enabled or disabled).Screenshots
Here are before and after screenshots. Note the red deactivate buttons become disabled for locations with nonzero inventory items.
Before:
After: