-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEO-1148 Bump dry-validation to 1.5 #222
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WoLkErSs
added
feature
Proposals, implementation of new features, or enhancement of existing features
wip
Work in progress
labels
Sep 22, 2020
chubchenko
changed the title
PEO-1148 | bump dry-validation to 1.5
PEO-1148 Bump dry-validation to 1.5
Oct 5, 2020
chubchenko
added
hold
The pull request is put on hold
and removed
wip
Work in progress
labels
Oct 5, 2020
WoLkErSs
added
wip
Work in progress
and removed
hold
The pull request is put on hold
labels
Oct 21, 2020
…ure/bump-dry-validation
WoLkErSs
added
need review
A developer has made the final commit and the pull request needs to be checked by reviewers
and removed
wip
Work in progress
labels
Oct 23, 2020
WoLkErSs
commented
Oct 23, 2020
@@ -142,29 +142,29 @@ | |||
context 'when invalid filterable column' do | |||
let(:available_columns) { create_available_columns(name: 'attribute_1', filterable: false) } | |||
|
|||
let(:errors) { { filter: [[0, [I18n.t('errors.filtering_column_valid?')]]] } } | |||
let(:errors) { { 0 => [I18n.t('dry_validation.errors.filtering_column_valid?')] } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rule is match to documentation
But for some reason it terurns just last key with message errors.
When we call contract from rails console we will get correct keys inheritance with filter
key.
Could some one explaine it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Proposals, implementation of new features, or enhancement of existing features
need review
A developer has made the final commit and the pull request needs to be checked by reviewers
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PEO-1148
Description
Bump dry-validation and tunned code
TODO:
Before submitting the merge request make sure the following are checked