Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEO-1148 Bump dry-validation to 1.5 #222

Closed
wants to merge 16 commits into from

Conversation

WoLkErSs
Copy link
Contributor

@WoLkErSs WoLkErSs commented Sep 22, 2020

PEO-1148

Description

Bump dry-validation and tunned code

TODO:

Before submitting the merge request make sure the following are checked

  • Followed the style guidelines of this project
  • Performed a self-review of own code
  • Wrote the tests that prove that fix is effective/that feature works

@WoLkErSs WoLkErSs added feature Proposals, implementation of new features, or enhancement of existing features wip Work in progress labels Sep 22, 2020
@WoLkErSs WoLkErSs self-assigned this Sep 22, 2020
@chubchenko chubchenko changed the title PEO-1148 | bump dry-validation to 1.5 PEO-1148 Bump dry-validation to 1.5 Oct 5, 2020
@chubchenko chubchenko added hold The pull request is put on hold and removed wip Work in progress labels Oct 5, 2020
@WoLkErSs WoLkErSs added wip Work in progress and removed hold The pull request is put on hold labels Oct 21, 2020
@WoLkErSs WoLkErSs added need review A developer has made the final commit and the pull request needs to be checked by reviewers and removed wip Work in progress labels Oct 23, 2020
@@ -142,29 +142,29 @@
context 'when invalid filterable column' do
let(:available_columns) { create_available_columns(name: 'attribute_1', filterable: false) }

let(:errors) { { filter: [[0, [I18n.t('errors.filtering_column_valid?')]]] } }
let(:errors) { { 0 => [I18n.t('dry_validation.errors.filtering_column_valid?')] } }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule is match to documentation
But for some reason it terurns just last key with message errors.
When we call contract from rails console we will get correct keys inheritance with filter key.
Could some one explaine it?

@chubchenko chubchenko closed this Feb 15, 2021
@chubchenko chubchenko deleted the feature/bump-dry-validation branch February 15, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Proposals, implementation of new features, or enhancement of existing features need review A developer has made the final commit and the pull request needs to be checked by reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants