Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

bundle outdated doesn't list all gems #1521

Closed
iGEL opened this issue Nov 9, 2011 · 6 comments
Closed

bundle outdated doesn't list all gems #1521

iGEL opened this issue Nov 9, 2011 · 6 comments
Assignees
Milestone

Comments

@iGEL
Copy link

iGEL commented Nov 9, 2011

I just tried the new bundle outdated command, but it didn't showed me any outdated gems, even though my capistrano is outdated.

$ bundle outdated
Fetching gem metadata from http://rubygems.org/........

Outdated gems included in the bundle:
  Your bundle is up to date!

$ bundle show capistrano
/Users/igel/.rvm/gems/ruby-1.9.2-p290@planb/gems/capistrano-2.8.0

$ bundle update capistrano
Fetching gem metadata from http://rubygems.org/........
Using rake (0.9.2) 
Using multi_json (1.0.3) 
… 
Using bundler (1.1.rc) 
Installing highline (1.6.5) 
Using net-ssh (2.2.1) 
Using net-scp (1.0.4) 
Using net-sftp (2.0.5) 
Using net-ssh-gateway (1.1.0) 
Installing capistrano (2.9.0) 
Using exception_notification (2.5.2) 
…
Using uglifier (1.0.3) 
Your bundle is updated! Use `bundle show [gemname]` to see where a bundled gem is installed.

$ ruby --version
ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-darwin10.8.0]
$ bundle --version
Bundler version 1.1.rc

Gonna attach my Gemfile and Gemfile.lock

@ghost ghost assigned joelmoss Nov 18, 2011
@indirect
Copy link
Member

@joelmoss, any chance you could take a look at this? We're trying to wrap up any outstanding 1.1 issues so we can release the (hopefully final) 1.1 RC. Thanks!

@joelmoss
Copy link
Contributor

@iGEL Please attach your Gemfile and Gemfil.lock thx

@iGEL
Copy link
Author

iGEL commented Nov 22, 2011

Sorry, I forgot to paste the link to the gist: https://gist.github.com/1351105

@indirect
Copy link
Member

@joelmoss any ideas?

@chuckd
Copy link

chuckd commented Dec 6, 2011

I've attempted a fix and can see the cause but don't know enough to help further. The problem seems to have arisen at
7cf8ae, which changed how the "current" spec is determined. Prior to that commit, current (then known as cs) was assigned like this:

cs = current_specs.find{|spec| spec.name == s.name }

but after the above commit this assignment was split into a conditional based on whether it's a git spec or not. In the case of a non-git spec, the above became

cs = s # where s is from definition.specs

The bug is that definition is unlocked: definition = Bundler.definition(true). So the later version comparison checks "2.9.0" > "2.9.0" and misses the fact that capistrano 2.8.0 is outdated.

@joelmoss
Copy link
Contributor

joelmoss commented Dec 7, 2011

Looking into this now guys. Sorry about the wait.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants