fix GemNotFound message in Resolver #3566
Conversation
| @@ -324,8 +324,8 @@ def verify_gemfile_dependencies_are_found!(requirements) | |||
| end | |||
| else | |||
| message = "Could not find gem '#{requirement}' " | |||
| if @index.source_types.include?(Bundler::Source::Rubygems) | |||
| message << "in any of the gem sources listed in your Gemfile." | |||
| if Bundler.definition.has_rubygems_remotes? | |||
There was a problem hiding this comment.
I'd prefer we didn't reference the Bundler.definition when not necessary, as it makes this method reliant on global state
There was a problem hiding this comment.
OK. So, perhaps Index#source_types should be re-implemented?
I don't understand how to find the Gemfile's sources from @index. I was thinking @index.sources.each {|source| source.sources} might be helpful, but after experimentation any source's source seems to always be empty.
Another simpler solution would be to remove this conditional completely so that the message here is always in any of the gem sources listed in your Gemfile or installed on this machine..
|
It is extremely uncommon to have zero sources, so I am fine with changing the hardcoded message. |
|
@indirect When you say to change the hardcoded message, do you mean that removing the conditional on line 327 of Resolver would be reasonable? |
|
yes, I think removing the conditional makes sense. |
Fixes #3564 (Beginner-friendly error message for misspelled or non-existent gem names).
Feedback from anyone is welcome.