This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[Resolver] Consider locked dependencies first #5101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems reasonable, is there an easy way to test this out? |
|
@indirect I used the bundle in the linked issue. I also should probably run this against the benchmarks |
|
My past experience has been that any change to the resolver will regress unless there is a test for it... worst case, put that gemfile into the realworld specs, but we need something for sure. |
|
I don't know for sure how to test this, other than coming up with a reasonable reproduction case |
segiddins
force-pushed
the
seg-resolver-consider-locked-deps-first
branch
from
ffa167b
to
fa8ebce
Compare
…ransitive children
segiddins
force-pushed
the
seg-resolver-consider-locked-deps-first
branch
from
fa8ebce
to
1d0f11b
Compare
|
Realworld spec added |
|
@bundlerbot r+ |
|
📌 Commit 6030a00 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jan 15, 2017
…, r=indirect [Resolver] Consider locked dependencies first Closes #5031 Closes #5095 \c @marcandre @indirect
|
☀️ Test successful - status-travis |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5031
Closes #5095
\c @marcandre @indirect