This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[SpecSet] Sort by name in #tsort #5707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for backwards compatibility, see issue #5696 for an example
|
Is the issue here that multiple gems have the same files, and a require needs to hit the correct gem first for things to work? |
Yup! updated PR description |
|
Looks good. @bundlerbot r+ |
|
📌 Commit 8165661 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jun 6, 2017
[SpecSet] Sort by name in #tsort Closes #5696 This is required for backwards compatibility, see issue #5696 for an example. The issue is that previous versions of bundler would have the load path in one (correct) order, and master has them in another (correct) order. So some projects depend on the load path ordering when multiple gems have the same requirable file. - [x] Test case
|
☀️ Test successful - status-travis |
|
Thanks for the fix! |
segiddins
pushed a commit
that referenced
this pull request
Jul 17, 2017
[SpecSet] Sort by name in #tsort Closes #5696 This is required for backwards compatibility, see issue #5696 for an example. The issue is that previous versions of bundler would have the load path in one (correct) order, and master has them in another (correct) order. So some projects depend on the load path ordering when multiple gems have the same requirable file. - [x] Test case (cherry picked from commit e32353b) # Conflicts: # spec/runtime/setup_spec.rb
|
Released in 1.15.2, sorry for the long delay |
schneems
added a commit
to heroku/heroku-buildpack-ruby
that referenced
this pull request
Jul 17, 2017
Includes this fix rubygems/bundler#5707.
|
No worries, today was the first time I've seen the bug in action. Thanks for the release. I'm going to push this out to Heroku as soon as I can heroku/heroku-buildpack-ruby#602. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5696
This is required for backwards compatibility, see
issue #5696 for an example. The issue is that previous versions of bundler would have the load path in one (correct) order, and master has them in another (correct) order. So some projects depend on the load path ordering when multiple gems have the same requirable file.