This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[CLI] Switch around the --strict option for bundle outdated #6030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bundlerbot r+ |
|
📌 Commit 14d611c has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Sep 14, 2017
[CLI] Switch around the --strict option for bundle outdated ### What was the end-user problem that led to this PR? The problem was > outdated would be more consistent to change --strict to --filter-strict and --update-strict to --strict ### What was your diagnosis of the problem? My diagnosis was > let's rename --strict to --filter-strict and rename the current --update-strict to --strict. In another ticket, later, we can expand the way outdated works to not need as many flags to show the relevant info ### What is your fix for the problem, implemented in this PR? My fix switches around the options, by just making `--strict` an alias that means something different on 2.0 than on 1.0 ### Why did you choose this fix out of the possible options? I chose this fix because it allowed keeping temporary 1.x compatibility, versus wholesale renaming of the option.
|
💔 Test failed - status-travis |
|
@bundlerbot retry |
bundlerbot
added a commit
that referenced
this pull request
Sep 14, 2017
[CLI] Switch around the --strict option for bundle outdated ### What was the end-user problem that led to this PR? The problem was > outdated would be more consistent to change --strict to --filter-strict and --update-strict to --strict ### What was your diagnosis of the problem? My diagnosis was > let's rename --strict to --filter-strict and rename the current --update-strict to --strict. In another ticket, later, we can expand the way outdated works to not need as many flags to show the relevant info ### What is your fix for the problem, implemented in this PR? My fix switches around the options, by just making `--strict` an alias that means something different on 2.0 than on 1.0 ### Why did you choose this fix out of the possible options? I chose this fix because it allowed keeping temporary 1.x compatibility, versus wholesale renaming of the option.
|
+1 - I didn't do a thorough review, but I'm cool with this. |
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was
What was your diagnosis of the problem?
My diagnosis was
What is your fix for the problem, implemented in this PR?
My fix switches around the options, by just making
--strictan alias that means something different on 2.0 than on 1.0Why did you choose this fix out of the possible options?
I chose this fix because it allowed keeping temporary 1.x compatibility, versus wholesale renaming of the option.