Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Add patch option in bundle config #6931

Merged
4 commits merged into from
Jan 29, 2019

Conversation

ankitkataria
Copy link
Contributor

@ankitkataria ankitkataria commented Jan 24, 2019

What was the end-user problem that led to this PR?

Issue #5994

What was your diagnosis of the problem?

As mentioned by @indirect I added a patch option in the bundler config, which by default is false. If set to true, patch level update are preferred if no update levels are specified.

What is your fix for the problem, implemented in this PR?

A patch level config option which can be opted into.

Copy link
Contributor

@greysteil greysteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some comments to ensure this is tested and make the description (and possibly option name) clearer to folks coming to it fresh.

More generally, I'm not sure why we want this as an option in bundle config (rather than having folks pass --patch explicitly when then run bundle update, but I might be missing context. I don't feel strongly enough to block it.

spec/commands/update_spec.rb Outdated Show resolved Hide resolved
man/bundle-config.ronn Outdated Show resolved Hide resolved
@ankitkataria
Copy link
Contributor Author

@greysteil I feel, the prefer_patch option in the config option will make it easier to turn it into a default settings later on based on usage, as @indirect pointed out in the issue. 😅

In the future, based on usage and other feedback, we may eventually default that setting to on rather than off

Copy link
Contributor

@greysteil greysteil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. 👍 from me, then!

@greysteil
Copy link
Contributor

@chrismo are you also 👍 ?

@indirect
Copy link
Member

@bundlerbot r=greysteil :)

ghost pushed a commit that referenced this pull request Jan 29, 2019
6931: Add patch option in bundle config r=greysteil a=ankitkataria

### What was the end-user problem that led to this PR?

Issue #5994 

### What was your diagnosis of the problem?

As mentioned by @indirect I added a `patch` option in the bundler config, which by default is false. If set to true, patch level update are preferred if no update levels are specified. 

### What is your fix for the problem, implemented in this PR?

A patch level config option which can be opted into. 



Co-authored-by: Ankit Kataria <ankitkataria28@gmail.com>
@ghost
Copy link

ghost commented Jan 29, 2019

Build succeeded

@ghost ghost merged commit 36b198e into rubygems:master Jan 29, 2019
@colby-swandale colby-swandale added this to the 2.1.0 milestone Feb 28, 2019
@deivid-rodriguez deivid-rodriguez removed this from the 2.1.0 milestone Dec 13, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants