-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some comments to ensure this is tested and make the description (and possibly option name) clearer to folks coming to it fresh.
More generally, I'm not sure why we want this as an option in bundle config (rather than having folks pass --patch
explicitly when then run bundle update
, but I might be missing context. I don't feel strongly enough to block it.
@greysteil I feel, the prefer_patch option in the config option will make it easier to turn it into a default settings later on based on usage, as @indirect pointed out in the issue. 😅
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. 👍 from me, then!
@chrismo are you also 👍 ? |
@bundlerbot r=greysteil :) |
6931: Add patch option in bundle config r=greysteil a=ankitkataria ### What was the end-user problem that led to this PR? Issue #5994 ### What was your diagnosis of the problem? As mentioned by @indirect I added a `patch` option in the bundler config, which by default is false. If set to true, patch level update are preferred if no update levels are specified. ### What is your fix for the problem, implemented in this PR? A patch level config option which can be opted into. Co-authored-by: Ankit Kataria <ankitkataria28@gmail.com>
Build succeeded |
What was the end-user problem that led to this PR?
Issue #5994
What was your diagnosis of the problem?
As mentioned by @indirect I added a
patch
option in the bundler config, which by default is false. If set to true, patch level update are preferred if no update levels are specified.What is your fix for the problem, implemented in this PR?
A patch level config option which can be opted into.