This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Get bundle exec respecting proc titles
#7140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This definitely seems like the right approach to me. |
spec/commands/exec_spec.rb
Outdated
| @@ -55,6 +55,13 @@ | |||
| expect(out).to eq("hi") | |||
| end | |||
|
|
|||
| it "respects custom process title when loading through ruby" do | |||
| create_file "Gemfile" | |||
| create_file "a.rb", 'Process.setproctitle("1-2-3-4-5-6-7-8-9-10-11-12-13-14-15-16"); puts `ps -eo args | grep [1]-2-3-4-5-6-7-8-9-10-11-12-13-14-15-16`' | |||
There was a problem hiding this comment.
I'm shelling out to ps in order to test this, since I couldn't think of a better way.
There was a problem hiding this comment.
I can't think of another way to do it, either. It may be worth adding a brief comment explaining how it's testing it, for folks less familiar with *nix tools.
There was a problem hiding this comment.
Thank you, I'll add a little comment. 👍
There was a problem hiding this comment.
I added a local variable with a long name, to explain what the test script is about 😃
deivid-rodriguez
force-pushed
the
fix_exec_proc_title
branch
from
ae16be3
to
a7d5467
Compare
|
Thanks for having a look @duckinator. I'll get this in! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Apr 29, 2019
7140: Get `bundle exec` respecting proc titles r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that `bundle exec` would not respect custom proctitles inside scripts. ### What was your diagnosis of the problem? My diagnosis was that the previous code was using the third form of `Kernel.exec`, documented as: > In the third form (exec(["command", "argv0"], "arg1", ...)), starting a two-element array at the beginning of the command, the first element is the command to be executed, and the second argument is used as the argv[0] value, which may show up in process listings. See https://ruby-doc.org/core-2.6.3/Kernel.html#method-i-exec. However, since this form messes with proc titles, it seems to affect scripts settting their own proc titles. ### What is your fix for the problem, implemented in this PR? My fix is to use the simpler form: > In the second form (exec("command1", "arg1", ...)), the first is taken as a command name and the rest are passed as parameters to command with no shell expansion. We were not passing any special proc title, so I don't think we need the third form, and this simpler form allows custom proc titles inside scripts to work just fine. ### Why did you choose this fix out of the possible options? I chose this fix because I couldn't figure out a better one. Closes #7135. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that
bundle execwould not respect custom proctitles inside scripts.What was your diagnosis of the problem?
My diagnosis was that the previous code was using the third form of
Kernel.exec, documented as:See https://ruby-doc.org/core-2.6.3/Kernel.html#method-i-exec.
However, since this form messes with proc titles, it seems to affect scripts settting their own proc titles.
What is your fix for the problem, implemented in this PR?
My fix is to use the simpler form:
We were not passing any special proc title, so I don't think we need the third form, and this simpler form allows custom proc titles inside scripts to work just fine.
Why did you choose this fix out of the possible options?
I chose this fix because I couldn't figure out a better one.
Closes #7135.