Bump net-http-persistent to 3.1.0 #7200
Conversation
|
I'm ✅ on upgrading the gem but i would much prefer we have the open PR in net-http-presistent merged first before merging this. |
|
Yeah. It's been ignored for two years now, though... 😬 |
|
Looking into the current status with drbrain/net-http-persistent#90. We probably don't have a choice, and the PR is fairly simple that i doubt it will cause an issue. So i'm 👍 on this. Can we just document (even just a comment in the Rakefile) that we've cherry-picked this change incase we need to reference it in the future. |
|
A comment about the cherry-pick sounds good, yeah. I'll add it 👍. |
|
Another downside of this PR is that the automatiek task for vendoring |
|
I'll try to fix the last issue I mentioned in |
deivid-rodriguez
force-pushed
the
bump_net_http_persistent
branch
from
e06ffb5
to
23004a2
Compare
|
I created a patch for automatiek and described in the PR's description how it would be used for this specific case: segiddins/automatiek#3. |
deivid-rodriguez
force-pushed
the
bump_net_http_persistent
branch
from
23004a2
to
772bd73
Compare
Rakefile
Outdated
| # We currently cherry-pick changes to use `require_relative` internally | ||
| # instead of regular `require`. These changes have already landed to fileutils | ||
| # master, but have not yet been released, so we cherry-pick them for the time | ||
| # being. |
There was a problem hiding this comment.
@hsbt If you have time, it would be nice to release fileutils master as fileutils-1.2.1, so we don't need to cherry-pick anything.
* Adds an extra artifice task to vendorize new `connection_pool` dependency. * Cherry-pick's needed Windows fix not yet merged into master branch of `net-http-persistent`. * Update bundler usages to be compatible with the new version, and fix unit specs.
deivid-rodriguez
force-pushed
the
bump_net_http_persistent
branch
from
772bd73
to
5c0570e
Compare
|
The net-http-persistent PR has been merged! Maybe we'll be able to jump straight to the next release 🎉 |
deivid-rodriguez
changed the title
|
Updated to use net-http-persistent 3.1.0, which was released yesterday, including the PR we needed. Only thing left here would be an But I don't think it's a hard requirement for this PR. |
|
This was approved by @hbst and @colby-swandale, so I'll merge it. Vendoring a future version of So no big deal, we can wait for the PR to be merged and reviewed, and update @bundlerbot r+ |
7200: Bump net-http-persistent to 3.1.0 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I wanted to propose some changes to this vendored gem, but I found out that we are using an old version of it. ### What was your diagnosis of the problem? My diagnosis was that we should upgrade. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade the dependency. Since it's a major update, it required some changes. Also, I had to: * Add a new artifice task to vendorize new `connection_pool` dependency. This is the main downside of this PR, that the new version adds a dependency on this gem. But this gem is very stable, and rarely changes and releases new versions, as can be seen by its [releases](https://github.com/mperham/connection_pool/releases). * Cherry-pick a Windows fix not yet merged into master branch of `net-http-persistent`: drbrain/net-http-persistent#90. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
|
Actually, the comment about @bundlerbot r- |
Canceled |
deivid-rodriguez
force-pushed
the
bump_net_http_persistent
branch
from
1bd53e1
to
ffb7d6f
Compare
|
Done, and also added a comment about the current @bundlerbot r+ |
7200: Bump net-http-persistent to 3.1.0 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that I wanted to propose some changes to this vendored gem, but I found out that we are using an old version of it. ### What was your diagnosis of the problem? My diagnosis was that we should upgrade. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade the dependency. Since it's a major update, it required some changes. Also, I had to: * Add a new artifice task to vendorize new `connection_pool` dependency. This is the main downside of this PR, that the new version adds a dependency on this gem. But this gem is very stable, and rarely changes and releases new versions, as can be seen by its [releases](https://github.com/mperham/connection_pool/releases). * Cherry-pick a Windows fix not yet merged into master branch of `net-http-persistent`: drbrain/net-http-persistent#90. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit 
What was the end-user problem that led to this PR?
The problem was that I wanted to propose some changes to this vendored gem, but I found out that we are using an old version of it.
What was your diagnosis of the problem?
My diagnosis was that we should upgrade.
What is your fix for the problem, implemented in this PR?
My fix is to upgrade the dependency. Since it's a major update, it required some changes. Also, I had to:
Add a new artifice task to vendorize new
connection_pooldependency. This is the main downside of this PR, that the new version adds a dependency on this gem. But this gem is very stable, and rarely changes and releases new versions, as can be seen by its releases.Cherry-pick a Windows fix not yet merged into master branch of
net-http-persistent: Sets a default pool size for Windows as Process::RLIMIT_NOFILE is not supported drbrain/net-http-persistent#90.