This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Wrap up bundle cache migration to current bundle package
#7389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think we need to keep this information in our docs. Users should read docs for the version they're using and the history of bundler distract her from the point of the docs, in my opinion.
Use the preferred `bundle cache` everywhere, but leave package as an alias. Remove duplicated tests.
deivid-rodriguez
force-pushed
the
normalize_bundle_cache
branch
from
cb06ff7
to
c9f6d2b
Compare
|
This essentially brings #4008 into master. That PR was merged to 2-0-dev, but was never incorporated. As I explained in #7249, I believe we can do this without backwards compatibility concerns, because |
|
@bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Oct 30, 2019
7389: Wrap up `bundle cache` migration to current `bundle package` r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that after #7249, we added the current `bundle package` functionality to the current `bundle cache` command, so that these commands are now aliases of each other. The initial plan was to do this in a more careful manner but we concluded that this was only _adding_ functionality to `bundle cache`, so not backwards incompatible. We still need to wrap up the original plan, where `bundle cache` is the preferred command. ### What is your fix for the problem, implemented in this PR? My fix is to migrate docs, tests and help text to use `bundle cache`, and to remove duplicated specs for `bundle cache` and `bundle package`, since they are testing the exact same code. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
Build succeeded |
ghost
merged commit
|
Thanks! |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 7, 2019
7389: Wrap up `bundle cache` migration to current `bundle package` r=indirect a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that after #7249, we added the current `bundle package` functionality to the current `bundle cache` command, so that these commands are now aliases of each other. The initial plan was to do this in a more careful manner but we concluded that this was only _adding_ functionality to `bundle cache`, so not backwards incompatible. We still need to wrap up the original plan, where `bundle cache` is the preferred command. ### What is your fix for the problem, implemented in this PR? My fix is to migrate docs, tests and help text to use `bundle cache`, and to remove duplicated specs for `bundle cache` and `bundle package`, since they are testing the exact same code. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit 5ba1360)
hsbt
added a commit
to ruby/ruby
that referenced
this pull request
Nov 11, 2019
Features:
- Add caller information to some deprecation messages to make them easier to fix [#7361](rubygems/bundler#7361)
- Reconcile `bundle cache` vs `bundle package` everywhere. Now in docs, CLI help and everywhere else `bundle cache` is the preferred version and `bundle package` remains as an alias [#7389](rubygems/bundler#7389)
- Display some basic `bundler` documentation together with ruby's RDoc based documentation [#7394](rubygems/bundler#7394)
Bugfixes:
- Fix typos deprecation message and upgrading docs [#7374](rubygems/bundler#7374)
- Deprecation warnings about `taint` usage on ruby 2.7 [#7385](rubygems/bundler#7385)
- Fix `--help` flag not correctly delegating to `man` when used with command aliases [#7388](rubygems/bundler#7388)
- `bundle add` should cache newly added gems if an application cache exists [#7393](rubygems/bundler#7393)
- Stop using an insecure folder as a "fallback home" when user home is not defined [#7416](rubygems/bundler#7416)
- Fix `bundler/inline` warning about `Bundler.root` redefinition [#7417](rubygems/bundler#7417)
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was that after #7249, we added the current
bundle packagefunctionality to the currentbundle cachecommand, so that these commands are now aliases of each other.The initial plan was to do this in a more careful manner but we concluded that this was only adding functionality to
bundle cache, so not backwards incompatible.We still need to wrap up the original plan, where
bundle cacheis the preferred command.What is your fix for the problem, implemented in this PR?
My fix is to migrate docs, tests and help text to use
bundle cache, and to remove duplicated specs forbundle cacheandbundle package, since they are testing the exact same code.