Added license information to versions. #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this? Would love to see this get merged. |
Closed
|
+1 on this -- closing #363 will most definitely help enterprisey Rubyists. |
|
👍 It would be nice to see the license before I download it and find out I have to GPL my project. |
ghost
mentioned this pull request
|
👍, I agree with @adkron. |
| @@ -262,6 +264,10 @@ def join_authors | |||
| self.authors = self.authors.join(', ') if self.authors.is_a?(Array) | |||
| end | |||
|
|
|||
| def join_licenses | |||
| self.licenses = self.licenses.join(', ') if self.licenses.is_a?(Array) | |||
There was a problem hiding this comment.
Let's check that it responds to join instead of checking if it is an array. 🎉
|
hi @adkron I've updated the commit. Cheers. |
adkron
added a commit
that referenced
this pull request
Nov 16, 2012
Added license information to versions.
adkron
added a commit
that referenced
this pull request
Jan 29, 2015
Added license information to versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The license is stored in the database upon creation of a new version. It is then made visible on the web and via the API. This addresses #363.
Existing gem versions will still need to have their license information backfilled, per #422.