Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove activesupport 6.x from dockerfile #168

Closed
sonalkr132 opened this issue Apr 17, 2022 · 4 comments
Closed

Remove activesupport 6.x from dockerfile #168

sonalkr132 opened this issue Apr 17, 2022 · 4 comments

Comments

@sonalkr132
Copy link
Member

We pinned activesupport to 6.1.5 in #167 to work around Shopify/krane#851. It would be nice to move off activesupport 6.1.
@simi
Copy link
Member

simi commented Apr 17, 2022

What about Shopify/krane#861? I was able to run krane locally with AS 7.

@simi
Copy link
Member

simi commented Apr 17, 2022

At https://shipit.rubygems.org/rubygems/shipit/production/deploys/2038 there was still used old image (using kubernetes-deploy under the hood having also krane command), you have to deploy new image manually to fix the problem if I understand it well.

@sonalkr132
Copy link
Member Author

Please feel to free to give it a try by removing the line I added in #167. AFAUI, as per #861 krane is not compatiable with activesupport 7.x.

@simi
Copy link
Member

simi commented Aug 20, 2022

fixed by c8e958d

@simi simi closed this as completed Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simi @sonalkr132