v2.3.7 #861
Merged
v2.3.7 #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothysmith0609
requested review from
stefanmb and
devonboyer
and removed request for
a team
|
Also related: #851. @timothysmith0609 an aside but we can reproduce this bug on our local shipit instance, which has not yet been upgraded to Rails 7. ActiveSupport 6.1.4.4 causes the issue, but downgrading to 6.1.4.3 does not. |
|
Can we get rid of the conditional and just always include that sublibrary, then? |
gigr
approved these changes
Jan 11, 2022
|
I dug a bit deeper and realized that while our shipit instance was running activesupport 6, the deploy task where we saw the failure was running activesupport 7. I think this is good to go. |
timothysmith0609
force-pushed
the
active_support_v7_fixes
branch
from
212851a to
c8dca4d
Compare
timothysmith0609
changed the title
gigr
approved these changes
Jan 11, 2022
This was referenced Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish with this PR?
We need to explicitly require
active_support/isolated_execution_state, otherwise aNameErroris raised (see image)How is this accomplished?
Add the requirement where we load all the other
active_supportdependenciesrails/rails issue for more context
What could go wrong?
Could result in a similar error if we're not requiring everything we need, though that seems unlikely.