-
Notifications
You must be signed in to change notification settings - Fork 285
No prebuilt binaries found (target=undefined ...) #486
Comments
Can you try v0.23.0? I upgraded prebuild-install there and that may have also fixed a bug with detection. |
Hello, I also tried 0.23.0 and all the listed versions from 0.20.0 on, but I always get the same error. Thank you |
The undefineds are the issue as you suspected. It means prebuilt-install can’t figure out what arch it is running on. If you open a console does the process global have arch and such defined? I’m also pretty sure someone else on Arch had issues before too. |
In dev console look defined process.platform -> process.arch -> process.versions.modules -> |
I tried to debug the extension but unfortunately the |
All of the code related to this is here: https://github.com/rubyide/vscode-ruby/blob/master/server/src/util/rebuilder.ts#L22-L42 |
FWIW, I'm also experiencing this on a Mac, fresh Code Insiders install. |
I have the same issue:
|
Right, so I am ABI 67 and @LMolr is 69. That's the issue since tree-sitter-ruby is living in the dark ages on 64. |
I downgraded to nodejs-lts-dubnium on Arch. IDK what @LMolr is doing. That ABI is non-existent. Either way,
|
ABI 64 is Electron 4 and 69 is Electron 4.0.4. 64 isn't exactly ancient :-P I'll push a PR to |
@BrandonShega what ABI is insiders running right now? |
@wingrunr21 the issue might go beyond the ABI version, given I downgraded to Node LTS (ABI 64) and still have these issues, don't you think? How would |
The ABI is based on electron (since the server runs within the VSCode instance) not the system installed node versions. I have no idea why all that stuff is coming back undefined. I think that's probably a |
Ah, makes sense. This is the Electron REPL.
|
Ahh. |
Sorry, but I am not familiar with electron. If I understand correctly, even if we have The strangest part is that on my Code installation, the dev console shows the values:
|
I am on the latest stable release which got shipped a couple of days ago. I am still facing this issue. Are there any updates on this? Thank you |
We are waiting for this to get merged. tree-sitter/tree-sitter-ruby#108 |
For a workaround (note you'll need build tooling installed on your machine): cd ~/.vscode/extensions/rebornix.ruby-0.24.0/server/node_modules/tree-sitter-ruby
npm install # this should trigger prebuild-install to build a binary but it will be for node.js not electron
npx prebuild -t 4.0.4 -r electron --strip This should get a binary built on your machine |
* package.json: expand to include electron 4.0.4 https://github.com/lgeiger/node-abi/blob/master/index.js#L71 rubyide/vscode-ruby#486 * Prebuild electron 4, 4.0.4, and 5 * ⬆️ tree-sitter-cli
|
Sorry, but still getting the error on v0.24.1 |
Same error even with this workaround. I am on v0.24.1 |
Welllllll awesome. @ranjan-purbey did it build the binary successfully? There must be a bug in I'm prioritizing #506 immediately. |
Yes, the build was successful |
Same, tried the workaround but no change. Using the latest insiders version on Mac. |
I started work on moving over to the WASM version this weekend. Almost done but need to test a few things as it isn't a direct swap-out and VSCode doesn't officially support WASM in extensions. |
#506 is the tracking issue for the WASM move. I'll use this issue to represent the general problem (eg I'll close this after shipping the WASM support and people verify it is working). |
I am having the EXACT. SAME. PROBLEM. I have spent 2 hours looking at building the binary workaround and still doesn't work. Looks like they just released a version that no one can use now (I even went and changed back to a python 2 extension). I guess we will just have to not have formatting/etc. until they release a fix... please let me know if any other work around has worked (to continue the path of using the npx prebuild -t 4.0.4 -r electron --strip build I would not have to mess with gyp and yea--time to code ugly...) |
@jessicabrady16 , @wingrunr21 said that he is converting prebuilt binaries to WASM. So, we are waiting until he finishes working. |
Hi all, I pushed a few PRs to tree-sitter tonight. The WASM build is not yet at feature parity with the node build so working to get it there. I also need to make sure the WASM implementation provides a good level of performance. I continue to think this is the right long-term solve though. I also dug into this specific problem more and identified a couple of things I can do to fix:
|
This only works if you use Python 2.x, fails with Python 3.x |
The workaround does not work for me either. I tried 0.24.0 and 0.24.1. Using python 2.7.10 and node 10.15.3. |
It's working with 0.24.2 👍
|
The move to the WASM distribution of |
* package.json: expand to include electron 4.0.4 https://github.com/lgeiger/node-abi/blob/master/index.js#L71 rubyide/vscode-ruby#486 * Prebuild electron 4, 4.0.4, and 5 * ⬆️ tree-sitter-cli Former-commit-id: 248c663f9aa63037eda72cdf9c74301fab2eb7b3 [formerly 5252a6b56960ab4b8d30ad7a883de48bcf118808] Former-commit-id: d130faef48a9f9393cc07685ac87fdce8d058e29
After installing the plugin on a fresh Code installation, I cannot start the language server due to missing prebuilt binaries.
Your environment
vscode-ruby
version: 0.22.3(Electron 4.1.4 Chrome 69.0.3497.128 Node.js 10.11.0 V8: 6.9.427.30-electron.0)
Expected behavior
Language server should start.
Actual behavior
In Output Window, the Ruby Language Server context shows the following error message:
NOTE: I don't know if the
undefined
values are an hint about the origin of the problem.The text was updated successfully, but these errors were encountered: