This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Fix for detecting rubocop output delimiter #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This would be a quick fix for rubyide#519. (I tested this quickly modifying the extensions js file) Given more thought it might be better to get the **first** instance of `FORMATTED_OUTPUT_DELIMITER`and not the last one to detect the end of rubocop diagnostics?
|
Hi, I resolved this in v0.25.0. This PR was still marked as draft and the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be a quick fix for #519. (I tested this quickly modifying the extensions js file)
Given more thought it might be better to get the first instance of
FORMATTED_OUTPUT_DELIMITERand not the last one to detect the end of rubocop diagnostics?Description of change and why it was needed here