This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Bugfix: Filter out linters that are disabled in the configuration. #550
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #531.
The getLinter() function just passes on the linter config (if it's an object), or continues with an empty object if it's any other values. This leads to unexpected behavior when setting a specific linter to
false
in the config. I.e. the linter is not disabled, as one would expect, but an empty linter configuration is used.This PR fixes the issue by explicitly filtering linter configs that are
false
before passing them on to getLinter().