Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Bugfix: Filter out linters that are disabled in the configuration. #550

Merged
merged 1 commit into from
Oct 19, 2019

Conversation

peret
Copy link
Contributor

@peret peret commented Oct 19, 2019

Fixes #531.

The getLinter() function just passes on the linter config (if it's an object), or continues with an empty object if it's any other values. This leads to unexpected behavior when setting a specific linter to false in the config. I.e. the linter is not disabled, as one would expect, but an empty linter configuration is used.

This PR fixes the issue by explicitly filtering linter configs that are false before passing them on to getLinter().

  • The build passes
  • TSLint is mostly happy
  • Prettier has been run

@wingrunr21
Copy link
Collaborator

Thanks. This was on my list to look into this weekend but you beat me to it!

@wingrunr21 wingrunr21 merged commit 39edb48 into rubyide:master Oct 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to disable linter
2 participants