Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hang in debug builds / don't strip debug builds #63

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Fix hang in debug builds / don't strip debug builds #63

merged 2 commits into from
Oct 7, 2024

Commits on Oct 4, 2024

  1. Fix hang in V8 debug builds 

    This is a partial cherry-pick of upstream commit v8/v8@8953e49478.

Shows up in debug builds because of a buggy sanity check when computing
relationships between command line flags.

Example of the hang:

    #include "v8.h"
    #include "libplatform/libplatform.h"
    int main(void) {
      // works: v8::V8::SetFlagsFromString("--gc-global --noincremental-marking");
      v8::V8::SetFlagsFromString("--gc-global");
      v8::V8::SetFlagsFromString("--noincremental-marking");
      v8::V8::InitializePlatform(v8::platform::NewDefaultPlatform().release());
      v8::V8::Initialize(); // hangs in ComputeFlagListHash when defined(DEBUG)
    }
    @bnoordhuis
    bnoordhuis committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    8feda0e View commit details
    Browse the repository at this point in the history

  2. Strip symbols in release builds only 

    Words cannot describe the rage one feels when you wait 30 minutes for
a debug build to compile, only to find out it's been stripped of actual
debug symbols.
    @bnoordhuis
    bnoordhuis committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    d8ba248 View commit details
    Browse the repository at this point in the history