-
Notifications
You must be signed in to change notification settings - Fork 93
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix segfault, handle symbol conversion correctly (#319)
Symbol::Description() normally returns a string, but when the symbol does not have a description, it returns undefined. The String::Utf8Value constructor requires that a v8::Context is active for the ToString operation it executes. ToString is a no-op for strings (hence no crash) but not for undefined. Add a Context::Scope to fix that. Fixes: #318
- Loading branch information
1 parent
5a03255
commit 8c13559
Showing
2 changed files
with
5 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters