Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symbols are not converted to JavaScript strings with .call(*args) #43

Open
eregon opened this issue Jan 27, 2022 · 1 comment
Open

Symbols are not converted to JavaScript strings with .call(*args) #43

eregon opened this issue Jan 27, 2022 · 1 comment

Comments

@eregon
Copy link

eregon commented Jan 27, 2022

From rails/execjs#110 (comment)

Unlike all other execjs backends, therubyrhino currently does not convert :some_symbol to "some_symbol" when passing it to JavaScript.
I think it would make sense to fix it in this gem.
@eregon eregon mentioned this issue Jan 27, 2022
Merged
@eregon
Copy link
Author

eregon commented Jan 27, 2022

Another possibility is to have this behavior only for ExecJS in https://github.com/rails/execjs/blob/39118e25f9c2ee40e475ac64653e66be6f4aecd0/lib/execjs/ruby_rhino_runtime.rb#L35.
What do you think is better/makes more sense?

eregon added a commit to eregon/execjs that referenced this issue Jan 27, 2022
@eregon
Skip test_symbol on RubyRhinoRuntime for now as it does not work yet
a4efba3 
* Waiting for a decision in rubyjs/therubyrhino#43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eregon