Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Card styling #56

Merged
merged 4 commits into from
Oct 30, 2019
Merged

[WIP] Card styling #56

merged 4 commits into from
Oct 30, 2019

Conversation

alicetragedy
Copy link
Collaborator

@alicetragedy alicetragedy commented Oct 30, 2019 •
edited
Loading

This PR changes some of the structure of the event cards on the landing page to be closer to our design in #53:

  • restructure the information visible on the event list for each event
  • move the placement of the donut chart and all related information (i.e. gender breakdown data)

Additionally, all typography-related content was moved to its own stylesheet for ease of use.

@alicetragedy alicetragedy changed the base branch from master to sidebar October 30, 2019 16:26
jancborchardt
jancborchardt approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, let’s merge it into the sidebar branch for more collaboration! :)

@jancborchardt jancborchardt merged commit 09b8320 into sidebar Oct 30, 2019
@jancborchardt jancborchardt deleted the card-styling branch October 30, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alicetragedy @jancborchardt