<video preload poster>, <audio preload> #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit cherry-picks the patch on html5lib's issue tracker: http://code.google.com/p/html5lib/issues/detail?id=205
This commit cherry-picks the patch on html5lib's issue tracker: http://code.google.com/p/html5lib/issues/detail?id=206
* planet/vendor/feedparser.py: Add preload and parser to the set of acceptable attributes. This is http://code.google.com/p/feedparser/issues/detail?id=356.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Sam,
These three commits add support to feedparser and html5lib for the preload and poster attributes of video and audio tags. I have already submitted them upstream as well. Please take a look.
I wanted to add preload=none to all video and audio tags, but that was not as straightforward as I would have liked, so this is a useful first step.
Regards,
Andy