Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle varieties of empty <georss:point> element #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle varieties of empty <georss:point> element #23

wants to merge 1 commit into from

Conversation

mloskot
Copy link

@mloskot mloskot commented Sep 4, 2013

Empty point defined as <georss:point> </georss:point> with single space only leads to index out of range on the coordinates access.

From the log:

ERROR:planet.runner:Error processing http://example.com/feed
ERROR:planet.runner:IndexError: list index out of range
ERROR:planet.runner:  File "/opt/venus/planet/spider.py", line 480, in spiderPlanet
    writeCache(uri, feed_info, data)
ERROR:planet.runner:  File "/opt/venus/planet/spider.py", line 228, in writeCache
    xdoc = reconstitute.reconstitute(data, entry)
ERROR:planet.runner:  File "/opt/venus/planet/reconstitute.py", line 315, in reconstitute
    location(xentry, (float)(coordinates[1]), (float)(coordinates[0]))

It looks rope-vim plugin I use with Vim automatically applied a bit of refactoring on unifying indentation. I hope it's not a showstopper :)
If it is a problem, let me know and I'll prepare clean patch.

Empty point defined as <georss:point> </georss:point> with single space only
leads to index out of range on the coordinates access.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant