Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heap overflow and information leak in zipruby #207

Closed
wants to merge 1 commit into from

Conversation

grosser
Copy link
Contributor

@grosser grosser commented Oct 21, 2015

@@ -0,0 +1,15 @@
---
gem: zipruby
cve: CVE-2012-1163
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just "2012-1163" (without the CVE- part)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

5.4.0 and <= 5.3.10) and the Ruby binding zipruby (version <= 0.3.6) are
also affected as they include copies of affected libzip versions.
patched_versions:
- ">= 0.3.6"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no versions currently released that are above this, should we really be putting this as patched versions? We can't guarantee that there will ever be a fixed version released...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By that I mean the latest commit in the repository is 2 days before the official release notice of libzip 0.10. Did they actually update it? I don't know much about C...
screen shot 2015-10-22 at 7 41 56 pm
screen shot 2015-10-22 at 7 42 02 pm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be > 0.3.6

@phillmv
Copy link
Member

phillmv commented Oct 22, 2015

OKAY. Thanks for all the pull requests @grosser!

If I understand this correctly, forever ago someone found a couple CVEs in libzip, which is used by zipruby, which has been totally abandoned.

In this light, there aren't any patched versions since https://rubygems.org/gems/zipruby/ shows that 0.3.6 is the last version that has been released, and the advisory claims that 0.3.6 is vulnerable. (Thanks, @VanessaHenderson)

@grosser, if you could please:

  • delete the 'patched_versions' line, since none exist
  • create one file per CVE, with the appropriate description (keep the url the same :))
  • while you're at it, change the title of the first one (2012-1162) to "zipruby is susceptible to a heap overflow", and the title of the other (2012-1163) to "A flaw in zipruby may allow information leaks"

and we should be good :).

@grosser
Copy link
Contributor Author

grosser commented Oct 22, 2015

updated, looking good ?

On Thu, Oct 22, 2015 at 8:06 AM, Phill MV notifications@github.com wrote:

OKAY. Thanks for all the pull requests @grosser
https://github.com/grosser!

If I understand this correctly, forever ago someone found a couple CVEs in
libzip, which is used by zipruby, which has been totally abandoned.

In this light, there aren't any patched versions since
https://rubygems.org/gems/zipruby/ shows that 0.3.6 is the last version
that has been released, and the advisory claims that 0.3.6 is vulnerable.
(Thanks, @VanessaHenderson https://github.com/VanessaHenderson)

@grosser https://github.com/grosser, if you could please:

  • delete the 'patched_versions' line, since they none exist
  • create one file per CVE, with the appropriate description (keep the
    url the same :))
  • while you're at it, change the title of the first one (2012-1162) to
    "zipruby is susceptible to a heap overflow", and the title of the other
    (2012-1163) to "A flaw in zipruby may allow information leaks"

and we should be good :).


Reply to this email directly or view it on GitHub
#207 (comment)
.

@grosser grosser closed this Dec 5, 2015
@grosser grosser deleted the grosser/memory branch December 5, 2015 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants